-
Notifications
You must be signed in to change notification settings - Fork 13.1k
metal : refactor + optimize v2 #15995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+7,870
−7,181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c02fbab
to
9b0d50c
Compare
a771b14
to
716a3d3
Compare
ggml-ci
ggml-ci
ggml-ci
ggml-ci
b01f087
to
bef9295
Compare
ggml-ci
ggml-ci
ggml-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Apple Metal
https://en.wikipedia.org/wiki/Metal_(API)
devops
improvements to build systems and github actions
ggml
changes relating to the ggml tensor library for machine learning
testing
Everything test related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of the Metal backend to make the implementation safer and more manageable:
ggml-metal-device.h
and move device code thereggml-metal-context.h
and move backend context code thereggml_metal_encode_node
into per-op functions and move them to separate sourcestypedef struct ggml_mem_ranges * ggml_mem_ranges_t;